Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt: add support for username and password #7243

Closed
wants to merge 1 commit into from
Closed

Conversation

@bagder
Copy link
Member

@bagder bagder commented Jun 11, 2021

Minor-edits-by: Daniel Stenberg
Added test 2200 to 2205

The combined work from #7221 and #7191, squashed and lightly edited by me.

Minor-edits-by: Daniel Stenberg
Added test 2200 to 2205
@Gealber
Copy link
Contributor

@Gealber Gealber commented Jun 11, 2021

On the continuous-integration/appveyor/pr there's a test failing:

TESTFAIL: These test cases failed: 676

I cannot see why it's failing, because this test wasn't modified on the pull request and is not related to MQTT, so is very unlikely to be using the server tests/server/mqttd.c.

The other one is test 2100 on curl.curl (windows windows msys1_mingw_debug_schannel)

Same situation as before, this is a test related to HTTP and hasn't been touched, so no idea why is failing.

@bagder
Copy link
Member Author

@bagder bagder commented Jun 12, 2021

That's just a flaky test, the failure is unrelated to this PR.

@bagder
Copy link
Member Author

@bagder bagder commented Jun 12, 2021

Thanks @Gealber!

@bagder bagder closed this in 791937b Jun 12, 2021
@bagder bagder deleted the bagder/mqtt-cred-combo branch Jun 12, 2021
Bastian-Krause added a commit to Bastian-Krause/curl that referenced this pull request Jul 21, 2021
PR curl#7243 implemented username/password support for MQTT, so let's drop
these items from the caveats.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause added a commit to Bastian-Krause/curl that referenced this pull request Jul 21, 2021
PR curl#7243 implemented username/password support for MQTT, so let's drop
these items from the caveats.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
bagder added a commit that referenced this pull request Jul 21, 2021
PR #7243 implemented username/password support for MQTT, so let's drop
these items from the caveats.

Signed-off-by: Bastian Krause <bst@pengutronix.de>

Closes #7474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants