examples: Simplify signal handler#7310
Closed
danielgustafsson wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
The signal handler registered for SIGINT is only handling SIGINT so there isn't much need for inspecting the signo. While there, rename the handler to be more specific. g_should_exit should really be of sig_atomic_t type, but relying on autoconf in the examples seems like a bad idea so keep tjat for now. Closes #xxxx
Contributor
|
I've just discovered that sig_atomic_t is part of C89, so you should be able to use that type here unconditionally. Examples aren't intended to be as fully portable as the rest of curl, anyway. It also means that I can just submit PR#7309 because there's no need to check if that type is available because it will be. |
bagder
approved these changes
Jun 29, 2021
danielgustafsson
added
the
feature-window
Contributor
|
IIRC, sig_atomic_t should be available just about everywhere that curl runs,
which I discovered when looking at #7309 which
means there should be no need for an autoconf test. But don't quote me on that,
because I stopped looking further when I discovered it simply isn't used in
curl.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signal handler registered for SIGINT is only handling SIGINT
so there isn't much need for inspecting the signo. While there,
rename the handler to be more specific.
g_should_exit should really be of sig_atomic_t type, but relying
on autoconf in the examples seems like a bad idea so keep tjat
for now.
Closes #xxxx