Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove libssh2 feature checks #7343

Closed
wants to merge 1 commit into from

Conversation

@Tachi107
Copy link
Contributor

@Tachi107 Tachi107 commented Jul 4, 2021

libssh2 features are detected based on version since commit 9dbbba9

@vszakats vszakats added the build label Jul 4, 2021
@Tachi107
Copy link
Contributor Author

@Tachi107 Tachi107 commented Jul 4, 2021

Forgot to remove set(CMAKE_EXTRA_INCLUDE_FILES "libssh2.h"), converting to draft

@Tachi107 Tachi107 marked this pull request as draft Jul 4, 2021
@Tachi107 Tachi107 force-pushed the Tachi107:cmake-libssh2-remove-checks branch from f10d108 to 3b846d5 Jul 4, 2021
@Tachi107 Tachi107 marked this pull request as ready for review Jul 4, 2021
libssh2 features are detected based on version since commit
9dbbba9
@Tachi107 Tachi107 force-pushed the Tachi107:cmake-libssh2-remove-checks branch from 3b846d5 to ab0bf03 Jul 4, 2021
@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Jul 4, 2021

I don't have a CMake environment handy to test on right now, but +1 on the concept.

@bagder bagder closed this in 4f3828d Jul 5, 2021
@bagder
Copy link
Member

@bagder bagder commented Jul 5, 2021

Thanks!

@Tachi107 Tachi107 deleted the Tachi107:cmake-libssh2-remove-checks branch Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants