Make Curl_gss_log_error more verbose #738

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@frenche
Contributor
frenche commented Mar 29, 2016

Dispaly also the GSS_C_GSS_CODE (major code) when specified,
instead of only GSS_C_MECH_CODE (minor code).

In addition, the old code was printing twice a colon after the
prefix and also miscalculated the length of the buffer in between
calls to gss_display_status (the length of ": " was missing).

Also, gss_buffer is not guaranteed to be NULL terminated and
need to restrict reading by its length.

Discussed over #723

@frenche frenche Make Curl_gss_log_error more verbose
Dispaly also the GSS_C_GSS_CODE (major code) when specified,
instead of only GSS_C_MECH_CODE (minor code).

In addition, the old code was printing twice a colon after the
prefix and also miscalculated the length of the buffer in between
calls to gss_display_status (the length of ": " was missing).

Also, gss_buffer is not guaranteed to be NULL terminated and
need to restrict reading by its length.
35f1ddb
@mention-bot

By analyzing the blame information on this pull request, we identified @captain-caveman2k, @jchaffraix and @bagder to be potential reviewers

@bagder bagder added a commit that closed this pull request Mar 29, 2016
@frenche @bagder frenche + bagder GSS: make Curl_gss_log_error more verbose
Also display the GSS_C_GSS_CODE (major code) when specified instead of
only GSS_C_MECH_CODE (minor code).

In addition, the old code was printing a colon twice after the prefix
and also miscalculated the length of the buffer in between calls to
gss_display_status (the length of ": " was missing).

Also, gss_buffer is not guaranteed to be NULL terminated and thus need
to restrict reading by its length.

Closes #738
d5fc6e1
@bagder bagder closed this in d5fc6e1 Mar 29, 2016
@bagder
Member
bagder commented Mar 29, 2016

Thanks, I fixed a mistake in a comment and a minor indentation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment