Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Curl_gss_log_error more verbose #738

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@iboukris
Copy link
Contributor

commented Mar 29, 2016

Dispaly also the GSS_C_GSS_CODE (major code) when specified,
instead of only GSS_C_MECH_CODE (minor code).

In addition, the old code was printing twice a colon after the
prefix and also miscalculated the length of the buffer in between
calls to gss_display_status (the length of ": " was missing).

Also, gss_buffer is not guaranteed to be NULL terminated and
need to restrict reading by its length.

Discussed over #723

Make Curl_gss_log_error more verbose
Dispaly also the GSS_C_GSS_CODE (major code) when specified,
instead of only GSS_C_MECH_CODE (minor code).

In addition, the old code was printing twice a colon after the
prefix and also miscalculated the length of the buffer in between
calls to gss_display_status (the length of ": " was missing).

Also, gss_buffer is not guaranteed to be NULL terminated and
need to restrict reading by its length.
@mention-bot

This comment has been minimized.

Copy link

commented Mar 29, 2016

By analyzing the blame information on this pull request, we identified @captain-caveman2k, @jchaffraix and @bagder to be potential reviewers

@bagder bagder closed this in d5fc6e1 Mar 29, 2016

@bagder

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

Thanks, I fixed a mistake in a comment and a minor indentation error.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.