Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: spell DoH with a lowercase o #7413

Closed
wants to merge 1 commit into from
Closed

cleanup: spell DoH with a lowercase o #7413

wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jul 16, 2021

https://en.wikipedia.org/wiki/DNS_over_HTTPS

curl/lib/doh.h

Line 31 in 3085ccf

* Curl_doh() resolve a name using DoH (DNS-over-HTTPS). It resolves a name

I'm not entirely certain about the full set of changes, as some might change the behavior of clients that are parsing output. Happy to drop any sets.

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Copy link
Contributor Author

@jsoref jsoref left a comment

These are the bits that seem the most risky

@@ -65,7 +65,7 @@ the correct end-point.
.SH DEFAULT
1
.SH PROTOCOLS
DOH
DoH
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less certain about this


Note that if this option is enabled but the server does not support the TLS
extension, the verification will fail.
.SH DEFAULT
0
.SH PROTOCOLS
DOH
DoH
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

infof(data, "a DoH request is completed, %u to go", dohp->pending);
if(result)
infof(data, "DOH request %s", curl_easy_strerror(result));
infof(data, "DoH request %s", curl_easy_strerror(result));
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pair changes output

@@ -768,7 +768,7 @@ static void showdoh(struct Curl_easy *data,
for(i = 0; i < d->numaddr; i++) {
const struct dohaddr *a = &d->addr[i];
if(a->type == DNS_TYPE_A) {
infof(data, "DOH A: %u.%u.%u.%u",
infof(data, "DoH A: %u.%u.%u.%u",
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

@@ -777,7 +777,7 @@ static void showdoh(struct Curl_easy *data,
char buffer[128];
char *ptr;
size_t len;
msnprintf(buffer, 128, "DOH AAAA: ");
msnprintf(buffer, 128, "DoH AAAA: ");
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

@@ -958,7 +958,7 @@ CURLcode Curl_doh_is_resolved(struct Curl_easy *data,
&de);
Curl_dyn_free(&p->serverdoh);
if(rc[slot]) {
infof(data, "DOH: %s type %s for %s", doh_strerror(rc[slot]),
infof(data, "DoH: %s type %s for %s", doh_strerror(rc[slot]),
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

@@ -969,7 +969,7 @@ CURLcode Curl_doh_is_resolved(struct Curl_easy *data,
struct Curl_dns_entry *dns;
struct Curl_addrinfo *ai;

infof(data, "DOH Host name: %s", dohp->host);
infof(data, "DoH Host name: %s", dohp->host);
Copy link
Contributor Author

@jsoref jsoref Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

bagder
bagder approved these changes Jul 16, 2021
Copy link
Member

@bagder bagder left a comment

I think this is generally good since everyone and the RFC use DoH these days. Originally the protocol was not written like that and that's the reason it snuck into curl with the uppercase o...

@bagder
Copy link
Member

@bagder bagder commented Jul 16, 2021

Thanks!

@jsoref jsoref deleted the DoH branch Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants