configure.ac: tweak nghttp2 library name fix again#7485
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
configure.ac: tweak nghttp2 library name fix again#7485jay wants to merge 1 commit intocurl:masterfrom
jay wants to merge 1 commit intocurl:masterfrom
Conversation
- Change extraction to handle multiple library names returned by pkg-config (eg a possible scenario with pkg-config --static). Ref: curl#7472 Closes #xxxx
bagder
approved these changes
Jul 24, 2021
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
This goes against the previous change a little, as that would adapt to whatever custom name the nghttp2 library has been given, while this change now requires the new name to contain 'nghttp2' at least. But if we don't want to revert the entire support for custom library names, I think this is the best approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg-config (eg a possible scenario with pkg-config --static).
Ref: #7472
Closes #xxxx