cookie_interface: avoid printing time_t directly#7490
Closed
carenas wants to merge 1 commit intocurl:masterfrom
Closed
cookie_interface: avoid printing time_t directly#7490carenas wants to merge 1 commit intocurl:masterfrom
carenas wants to merge 1 commit intocurl:masterfrom
Conversation
time_t representation is undefined and varies on bitsize and signedness, and as of C11 could be even non integer. instead of casting to unsigned long (which would truncate in systems with a 32bit long after 2106) use difftime to get the elapsed time as a double and print that (without decimals) instead. alternatively a cast to curl_off_t and its corresponding print formatting could have been used (at least in POSIX) but portability and curl agnostic code was prioritized.
bagder
approved these changes
Jul 25, 2021
Member
|
Thanks! |
Member
|
Unfortunately, this caused scan-build to yell: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time_t representation is undefined and varies on bitsize and signedness,
and as of C11 could be even non integer.
instead of casting to unsigned long (which would truncate in systems with
a 32bit long after 2106) use difftime to get the elapsed time as a double
and print that (without decimals) instead.
alternatively a cast to curl_off_t and its corresponding print formatting
could have been used (at least in POSIX) but portability and curl agnostic
code was prioritized.