Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_url_strerror() for CURLUcode #7605

Closed
wants to merge 5 commits into from
Closed

curl_url_strerror() for CURLUcode #7605

wants to merge 5 commits into from

Conversation

@i-ky
Copy link
Contributor

@i-ky i-ky commented Aug 21, 2021

  1. Add curl_url_strerror() to convert CURLUcode into readable string and facilitate easier troubleshooting in programs using URL API.
  2. Extend CURLUcode with CURLUE_LAST for iteration in unit tests.
  3. Update man pages with a mention of new function.
  4. Update example code and tests with new functionality where it fits.

P.S. Target version will need to be updated since 7.79.0 is already frozen.

Add curl_url_strerror() to convert CURLUcode into readable string and
facilitate easier troubleshooting in programs using URL API.
Extend CURLUcode with CURLU_LAST for iteration in unit tests.
Update man pages with a mention of new function.
Update example code and tests with new functionality where it fits.
@bagder
Copy link
Member

@bagder bagder commented Aug 21, 2021

Ah, just this little thing...

./strerror.c:465:81: warning: Longer than 79 columns (LONGLINE)
     return "An argument that should be a CURLU pointer was passed in as a NULL";

@i-ky
Copy link
Contributor Author

@i-ky i-ky commented Aug 21, 2021

Ah, just this little thing...

Fixed now. Excuse me for abusing CI pipeline a bit.

As far as I understand remaining failures are due to 4e53b94#commitcomment-55239253

lib/strerror.c Outdated Show resolved Hide resolved
lib/strerror.c Outdated Show resolved Hide resolved
bagder added a commit that referenced this issue Aug 23, 2021
CURLUE_BAD_HANDLE and CURLUE_BAD_PARTPOINTER should be for "bad" or
wrong pointers in a generic sense, not just for NULL pointers.

Ref: #7605
bagder added a commit that referenced this issue Aug 23, 2021
CURLUE_BAD_HANDLE and CURLUE_BAD_PARTPOINTER should be for "bad" or
wrong pointers in a generic sense, not just for NULL pointers.

Reviewed-by: Jay Satiro

Ref: #7605
Closes #7611
@bagder
Copy link
Member

@bagder bagder commented Sep 27, 2021

Thanks!

@bagder bagder closed this in 3363eeb Sep 27, 2021
@i-ky i-ky deleted the curl_url_strerror branch Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants