symbols-in-versions: fix CURLSSLBACKEND_QSOSSL removed version#7609
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
symbols-in-versions: fix CURLSSLBACKEND_QSOSSL removed version#7609jay wants to merge 1 commit intocurl:masterfrom
jay wants to merge 1 commit intocurl:masterfrom
Conversation
Member
|
Yeah, last sounds like a better field name. I don't remember how I did that scan but I'm pretty sure it was a custom perl script I wrote for that specific purpose and I don't think I kept it, I'm sorry to say. Trying to repeat it,, it would probably check what's in the public headers for release tags over time. |
Contributor
Yes, I agree, that's how I interpreted it. When I pushed the qsossl removal commit, |
... and also change the 'Removed' column name to 'Last' since that column is for the last version to contain the symbol. Closes #xxxx
jay
force-pushed
the
fix_qsossl_removed_version
branch
2 times, most recently
from
755bfd5 to
c65cfa1
Compare
bagder
approved these changes
Aug 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxx
IMO it might be clearer to call the symbols-in-versions 'Removed' version field as 'Last'. When someone says xxx was removed in yyy most would interpret that as xxx isn't in yyy, but in this case removed refers to last version that featured symbol. Also @bagder e765afc says you have a tool for this... don't suppose you remember from 10 years ago... could use another scan.
/cc @monnerat