Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbols-in-versions: fix CURLSSLBACKEND_QSOSSL removed version #7609

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Aug 22, 2021

Closes #xxxx


IMO it might be clearer to call the symbols-in-versions 'Removed' version field as 'Last'. When someone says xxx was removed in yyy most would interpret that as xxx isn't in yyy, but in this case removed refers to last version that featured symbol. Also @bagder e765afc says you have a tool for this... don't suppose you remember from 10 years ago... could use another scan.

/cc @monnerat

@bagder
Copy link
Member

@bagder bagder commented Aug 22, 2021

Yeah, last sounds like a better field name. I don't remember how I did that scan but I'm pretty sure it was a custom perl script I wrote for that specific purpose and I don't think I kept it, I'm sorry to say. Trying to repeat it,, it would probably check what's in the public headers for release tags over time.

@monnerat
Copy link
Contributor

@monnerat monnerat commented Aug 22, 2021

When someone says xxx was removed in yyy most would interpret that as xxx isn't in yyy,

Yes, I agree, that's how I interpreted it. When I pushed the qsossl removal commit, LIBCURL_VERSION was 7.38.1-DEV, but the next actual version tag was not yet known. Using last rather than removed clearly allows to only deal with established tagged version numbers at a given time.

... and also change the 'Removed' column name to 'Last' since that
column is for the last version to contain the symbol.

Closes #xxxx
@jay jay force-pushed the fix_qsossl_removed_version branch 2 times, most recently from 755bfd5 to c65cfa1 Aug 22, 2021
bagder
bagder approved these changes Aug 22, 2021
@jay jay closed this in d5a2706 Aug 23, 2021
@jay jay deleted the fix_qsossl_removed_version branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants