Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL: trace SSL3_MT_SUPPLEMENTAL_DATA #7652

Closed
wants to merge 2 commits into from
Closed

OpenSSL: trace SSL3_MT_SUPPLEMENTAL_DATA #7652

wants to merge 2 commits into from

Conversation

@gvanem
Copy link
Contributor

@gvanem gvanem commented Aug 31, 2021

I got annoyed by seeing all those TLSv1.2 (IN), TLS header, Unknown (23): in the -v trace.
So this fix is now printing:

* TLSv1.2 (OUT), TLS header, Supplemental data (23):

I hope this is a proper fix.

I got annoyed by seeing all those `TLSv1.2 (IN), TLS header, Unknown (23):` in the `-v` trace.
So this fix is now printing:
```
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
```
bagder
bagder approved these changes Aug 31, 2021
Copy link
Member

@bagder bagder left a comment

Looks correct to me!

@bagder
Copy link
Member

@bagder bagder commented Aug 31, 2021

./vtls/openssl.c:2066:12: warning: Trailing whitespace (TRAILINGSPACE)
 #endif      
            ^

Effin github editor. What is leaving trailing white-space good for?
@gvanem
Copy link
Contributor Author

@gvanem gvanem commented Aug 31, 2021

Trailing whitespace removed. Okay to Rebase and merge?

@bagder
Copy link
Member

@bagder bagder commented Aug 31, 2021

I advice against using the UI/button for git operations because it is much harder to figure out exactly what happens and that the commit message etc is done correctly.

For example, your commit message could benefit from these edits:

  1. wrap after column 72
  2. mention closes #7652 on a line of its own

It is much better to squash the commit locally, edit the commit message to be fine, then merge that into the master branch and push from there to "origin/master".

@gvanem
Copy link
Contributor Author

@gvanem gvanem commented Sep 1, 2021

Most of these git-terms are alien to me. And it's too much hassle to clone, edit, push. Should be easier to use the Web-UI directly.

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Sep 1, 2021

@bagder
Copy link
Member

@bagder bagder commented Sep 1, 2021

Should be easier to use the Web-UI directly.

I wouldn't mind that either. But I also want our commits and commits messages to be as good as possible, and I don't think github helps us good enough with that.

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Sep 1, 2021

I can push it for you with the edits requested below if you would prefer that.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants