Closed
Conversation
The file format for each option now features a "Example:" header that can provide one or more examples that get rendered appropriately in the output. All options MUST have at least one example or gen.pl complains at build-time. This fix also does a few other minor format and consistency cleanups.
bagder
force-pushed
the
bagder/curl-1-examples
branch
from
b9b2ec4 to
ad53b9a
Compare
danielgustafsson
approved these changes
Sep 1, 2021
Member
danielgustafsson
left a comment
danielgustafsson
left a comment
There was a problem hiding this comment.
My eyes admittedly glazed over a bit, but I didn't see any sharp bits sticking out anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file format for each option now features a "Example:" header that
can provide one or more examples that get rendered appropriately in the
output. The idea is that all options must have at least one example or
there will be a build failure.
This fix also does a few other minor format and consistency cleanups.