docs/examples/*hiperfifo.c: (nit) fix calloc arguments to match up with the function prototype#7678
Closed
git-bruh wants to merge 1 commit intocurl:masterfrom
git-bruh:master
Closed
docs/examples/*hiperfifo.c: (nit) fix calloc arguments to match up with the function prototype#7678git-bruh wants to merge 1 commit intocurl:masterfrom git-bruh:master
git-bruh wants to merge 1 commit intocurl:masterfrom
git-bruh:master
Conversation
…th the function prototype
bagder
approved these changes
Sep 6, 2021
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Very nit-picky, but accurate! 😁
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nelem and elsize fields were flipped in these examples, doesn't cause issues practically since it's just multiplying both the values but it's inconsistent with the argument names in the function prototype for calloc.