Closed
Conversation
danielgustafsson
approved these changes
Sep 20, 2021
Member
danielgustafsson
left a comment
danielgustafsson
left a comment
There was a problem hiding this comment.
These seem all fine to me, thanks! They will be squashed to a single commit before merging into master, but the committer can take care of that.
danielgustafsson
added
the
feature-window
Member
|
This is not a feature of course, but I don't see any reason to merge more than we have to for the minor release going out. This can wait for 7.80 IMO. |
Contributor
Author
|
Sure, I can squish them all. Is there a recommended commit message you'd like me to use? It is fixing typos in many separate files from different parts of the codebase. |
Member
|
Sure, I can squish them all. Is there a recommended commit message you'd like me to use? It is fixing typos in many separate files from different parts of the codebase.
Thanks! I would use "misc: fix typos in docs and comments" and then mention in the commit message that no user facing output from curl/libcurl is changed by this, just comments.
|
No user facing output from curl/libcurl is changed by this, just comments.
Contributor
Author
|
Squashed commits and reworded commit message. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comments are very welcome, so that I can improve the commit messages if needed.