Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #7747

Closed
wants to merge 1 commit into from
Closed

Fix typos #7747

wants to merge 1 commit into from

Conversation

@a1346054
Copy link
Contributor

@a1346054 a1346054 commented Sep 19, 2021

Review comments are very welcome, so that I can improve the commit messages if needed.

Copy link
Member

@danielgustafsson danielgustafsson left a comment

These seem all fine to me, thanks! They will be squashed to a single commit before merging into master, but the committer can take care of that.

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Sep 20, 2021

This is not a feature of course, but I don't see any reason to merge more than we have to for the minor release going out. This can wait for 7.80 IMO.

@a1346054
Copy link
Contributor Author

@a1346054 a1346054 commented Sep 20, 2021

Sure, I can squish them all. Is there a recommended commit message you'd like me to use? It is fixing typos in many separate files from different parts of the codebase.

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Sep 20, 2021

No user facing output from curl/libcurl is changed by this, just
comments.
@a1346054
Copy link
Contributor Author

@a1346054 a1346054 commented Sep 20, 2021

Squashed commits and reworded commit message.

@bagder bagder closed this in 7cf5e8e Sep 23, 2021
@bagder
Copy link
Member

@bagder bagder commented Sep 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants