Skip to content

Redundant code, branch that will not be executed #7770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
h1wind wants to merge 2 commits into from
Closed

Redundant code, branch that will not be executed #7770

h1wind wants to merge 2 commits into from

Conversation

@h1wind
Copy link

@h1wind h1wind commented Sep 24, 2021

No description provided.

bagder
bagder approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@bagder bagder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, since e->prev will only be NULL if it is the head node and the check on line 100 is already taking care of that!

@bagder
Copy link
Member

bagder commented Sep 24, 2021

Code style nit:

./llist.c:109:7: warning: if with space (SPACEBEFOREPAREN)
     if (e->prev)
       ^

@bagder bagder closed this in ecfc96c Sep 24, 2021
@bagder
Copy link
Member

bagder commented Sep 24, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h1wind @bagder