Skip to content

Redundant code, branch that will not be executed - #7770

Closed
okning wants to merge 2 commits into
curl:masterfrom
okning:h1zzz-patch-1
Closed

Redundant code, branch that will not be executed#7770
okning wants to merge 2 commits into
curl:masterfrom
okning:h1zzz-patch-1

Conversation

@okning

@okning okning commented Sep 24, 2021

Copy link
Copy Markdown

No description provided.

bagder
bagder approved these changes Sep 24, 2021
View reviewed changes

@bagder bagder left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, since e->prev will only be NULL if it is the head node and the check on line 100 is already taking care of that!

@bagder

bagder commented Sep 24, 2021

Copy link
Copy Markdown
Member

Code style nit:

./llist.c:109:7: warning: if with space (SPACEBEFOREPAREN)
     if (e->prev)
       ^

@bagder bagder closed this in ecfc96c Sep 24, 2021
@bagder

bagder commented Sep 24, 2021

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@okning @bagder