Remove leftover WinSock v1 checks - #7778
Closed
MarcelRaad wants to merge 3 commits into
Closed
MarcelRaad wants to merge 3 commits into
MarcelRaad wants to merge 3 commits into
Conversation
It's not supported anymore. Closes curl#7778
That's the only version we support. Closes curl#7778
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of support since 2013). Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10) Closes curl#7778
MarcelRaad
force-pushed
the
remove_winsock1_checks
branch
from
September 27, 2021 08:45
bb87d95 to
e66035f
Compare
mback2k
reviewed
Sep 27, 2021
mback2k
approved these changes
Sep 27, 2021
MarcelRaad
added a commit
that referenced
this pull request
Sep 28, 2021
That's the only version we support. Closes #7778
MarcelRaad
added a commit
that referenced
this pull request
Sep 28, 2021
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of support since 2013). Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10) Closes #7778
Member
Author
|
Thanks for the reviews and comments! |
Member
|
@MarcelRaad didn't you check that all Windows CI passes at least the build stage? There are quite some compilation errors. Please take another look. |
Member
|
#7788 fixes the problem I ran into after this was merged |
Member
Author
|
I actually did in my fork, and the change from #7788 is present in my local branch, just not in what landed on master and was pushed somewhere else. No idea how that could happen. Sorry about that, and thanks for the fix! |
Member
|
That fix doesn’t seem to fix the compilation errors. Most Azure and Cirrus Windows CI builds still fail due to: Maybe the old header is still needed after all? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require Winsock 2.2 since commit 3e4b32a,