Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover WinSock v1 checks #7778

Closed
wants to merge 3 commits into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Sep 27, 2021

We require Winsock 2.2 since commit 3e4b32a,

MarcelRaad added 3 commits Sep 27, 2021
It's not supported anymore.

Closes curl#7778
That's the only version we support.

Closes curl#7778
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of
support since 2013).

Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10)

Closes curl#7778
@MarcelRaad MarcelRaad force-pushed the remove_winsock1_checks branch from bb87d95 to e66035f Sep 27, 2021
bagder
bagder approved these changes Sep 27, 2021
Copy link
Member

@bagder bagder left a comment

Nice!

lib/setup-win32.h Show resolved Hide resolved
MarcelRaad pushed a commit that referenced this issue Sep 28, 2021
That's the only version we support.

Closes #7778
MarcelRaad pushed a commit that referenced this issue Sep 28, 2021
WinSock 2.2 is supported by Windows CE .NET 4.1 (from 2002, out of
support since 2013).

Ref: https://docs.microsoft.com/en-us/previous-versions/windows/embedded/ms899586(v=msdn.10)

Closes #7778
@MarcelRaad MarcelRaad deleted the remove_winsock1_checks branch Sep 28, 2021
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Sep 28, 2021

Thanks for the reviews and comments!

@mback2k
Copy link
Member

@mback2k mback2k commented Sep 28, 2021

@MarcelRaad didn't you check that all Windows CI passes at least the build stage? There are quite some compilation errors. Please take another look.

@bagder
Copy link
Member

@bagder bagder commented Sep 28, 2021

#7788 fixes the problem I ran into after this was merged

@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Sep 28, 2021

I actually did in my fork, and the change from #7788 is present in my local branch, just not in what landed on master and was pushed somewhere else. No idea how that could happen. Sorry about that, and thanks for the fix!

@mback2k
Copy link
Member

@mback2k mback2k commented Sep 29, 2021

That fix doesn’t seem to fix the compilation errors. Most Azure and Cirrus Windows CI builds still fail due to:

configure: error: Cannot find a type to use in place of in_addr_t

Maybe the old header is still needed after all?

@bagder
Copy link
Member

@bagder bagder commented Sep 29, 2021

Yeah, #7788 gets lots of CI build failures on Windows with that in_addr_t problem. I'm thinking we need to revert that commit until we have this fixed correctly: #7790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants