Fix some deprecation issues with OpenSSL 3.0 - #7808
Conversation
|
I just noticed the bad naming in sha256.c, where I used the Curl_ prefix for TU-local/static functions and types. Any better idea that won't clash with the names in any external SSL backend? |
Static functions don't need to be |
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Looks good to me. For some reason the zuul build doesn't show up now!
Only use OpenSSL's MD5 code if it's available. Also fix wolfSSL build with `NO_MD5`, in which case neither the wolfSSL/OpenSSL implementation nor the fallback implementation was used. Closes curl#7808
This selects another SSL backend then if available, or otherwise at least gives a meaningful error message. Closes curl#7808
Available since OpenSSL 0.9.7. The low-level SHA256 interface is deprecated in OpenSSL v3, and its usage was discouraged even before. Closes curl#7808
Strange. Looks like it disappeared for all PRs on October 1 and for the master branch on September 30. Now it shows as successful for this one... |
```
In file included from _bld/lib/CMakeFiles/libcurl_static.dir/Unity/unity_0_c.c:85:
lib/curl_ntlm_core.c:157:27: error: unknown type name 'DES_key_schedule'
DES_key_schedule DESKEYARG(ks))
^
lib/curl_ntlm_core.c:159:3: error: use of undeclared identifier 'DES_cblock'
DES_cblock key;
^
[...]
```
Earlier patch addressing this for OpenSSL:
802d864 curl#7808
Cherry-picked from curl#14495
Closes curl#14512
E.g. with Homebrew wolfssl 5.7.2 on macOS:
```
In file included from _bld/lib/CMakeFiles/libcurl_static.dir/Unity/unity_0_c.c:85:
lib/curl_ntlm_core.c:157:27: error: unknown type name 'DES_key_schedule'
DES_key_schedule DESKEYARG(ks))
^
lib/curl_ntlm_core.c:159:3: error: use of undeclared identifier 'DES_cblock'
DES_cblock key;
^
[...]
```
Earlier patch addressing this for OpenSSL:
802d864 #7808
Cherry-picked from #14495
Closes #14512
3 participants
This should fix everything except openssl.c itself, which requires more work as some of the functions used there are deprecated without a replacement.