Fix some deprecation issues with OpenSSL 3.0 #7808

MarcelRaad · 2021-10-03T21:11:07Z

This should fix everything except openssl.c itself, which requires more work as some of the functions used there are deprecated without a replacement.

MarcelRaad · 2021-10-03T21:12:39Z

I just noticed the bad naming in sha256.c, where I used the Curl_ prefix for TU-local/static functions and types. Any better idea that won't clash with the names in any external SSL backend?

bagder · 2021-10-04T08:32:44Z

Any better idea that won't clash with the names in any external SSL backend?

Static functions don't need to be Curl_ prefixed at all. If you still want the functions to have a prefix, you're free to select one you like that's specific for that single source file. In some cases we've used my_ then but there's no fixed rule.

Only use OpenSSL's MD5 code if it's available. Also fix wolfSSL build with `NO_MD5`, in which case neither the wolfSSL/OpenSSL implementation nor the fallback implementation was used. Closes curl#7808

This selects another SSL backend then if available, or otherwise at least gives a meaningful error message. Closes curl#7808

Available since OpenSSL 0.9.7. The low-level SHA256 interface is deprecated in OpenSSL v3, and its usage was discouraged even before. Closes curl#7808

bagder

Looks good to me. For some reason the zuul build doesn't show up now!

Only use OpenSSL's MD5 code if it's available. Also fix wolfSSL build with `NO_MD5`, in which case neither the wolfSSL/OpenSSL implementation nor the fallback implementation was used. Closes curl#7808

This selects another SSL backend then if available, or otherwise at least gives a meaningful error message. Closes curl#7808

Available since OpenSSL 0.9.7. The low-level SHA256 interface is deprecated in OpenSSL v3, and its usage was discouraged even before. Closes curl#7808

MarcelRaad · 2021-10-07T17:18:57Z

For some reason the zuul build doesn't show up now!

Strange. Looks like it disappeared for all PRs on October 1 and for the master branch on September 30.
And there are also older PRs where it's still shown as in progress: https://github.com/curl/curl/pull/7799/checks

Now it shows as successful for this one...

MarcelRaad pushed a commit to MarcelRaad/curl that referenced this issue Oct 4, 2021

curl_ntlm_core: use OpenSSL only without OPENSSL_NO_DES

afd94f2

This selects another SSL backend then if available, or otherwise at least gives a meaningful error message. Closes curl#7808

MarcelRaad pushed a commit to MarcelRaad/curl that referenced this issue Oct 4, 2021

sha256: use high-level EVP interface for OpenSSL

85d0866

Available since OpenSSL 0.9.7. The low-level SHA256 interface is deprecated in OpenSSL v3, and its usage was discouraged even before. Closes curl#7808

MarcelRaad force-pushed the opensslv3 branch from 03a6d85 to 85d0866 Oct 4, 2021

bagder approved these changes Oct 4, 2021

View changes

MarcelRaad added 3 commits Oct 7, 2021

md5: fix compilation with OpenSSL 3.0 API

b352e03

Only use OpenSSL's MD5 code if it's available. Also fix wolfSSL build with `NO_MD5`, in which case neither the wolfSSL/OpenSSL implementation nor the fallback implementation was used. Closes curl#7808

curl_ntlm_core: use OpenSSL only if DES is available

802d864

This selects another SSL backend then if available, or otherwise at least gives a meaningful error message. Closes curl#7808

sha256: use high-level EVP interface for OpenSSL

94696e1

Available since OpenSSL 0.9.7. The low-level SHA256 interface is deprecated in OpenSSL v3, and its usage was discouraged even before. Closes curl#7808

MarcelRaad force-pushed the opensslv3 branch from 85d0866 to 94696e1 Oct 7, 2021

MarcelRaad closed this in b352e03 Oct 7, 2021

MarcelRaad merged commit 94696e1 into curl:master Oct 7, 2021
46 of 50 checks passed

MarcelRaad deleted the opensslv3 branch Oct 11, 2021

mback2k added the hacktoberfest-accepted label Oct 27, 2021

curl / curl Public

Fix some deprecation issues with OpenSSL 3.0 #7808

Fix some deprecation issues with OpenSSL 3.0 #7808

MarcelRaad commented Oct 3, 2021

MarcelRaad commented Oct 3, 2021

bagder commented Oct 4, 2021

bagder left a comment

MarcelRaad commented Oct 7, 2021 •

edited

curl / curl Public

Fix some deprecation issues with OpenSSL 3.0 #7808

Fix some deprecation issues with OpenSSL 3.0 #7808

Conversation

MarcelRaad commented Oct 3, 2021

MarcelRaad commented Oct 3, 2021

bagder commented Oct 4, 2021

bagder left a comment

MarcelRaad commented Oct 7, 2021 • edited

MarcelRaad commented Oct 7, 2021 •

edited