Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues on MidnightBSD #7812

Closed
wants to merge 2 commits into from
Closed

Fix a few issues on MidnightBSD #7812

wants to merge 2 commits into from

Conversation

@laffer1
Copy link
Contributor

@laffer1 laffer1 commented Oct 4, 2021

No description provided.

@@ -2050,6 +2050,10 @@ AC_DEFUN([CURL_CHECK_FUNC_GETADDRINFO], [
dnl hpux 11.11 and newer
tst_tsafe_getaddrinfo="yes"
;;
midnightbsd*)
dnl all MidnightBSD versions
Copy link
Member

@danielgustafsson danielgustafsson Oct 4, 2021

Why does it say "all versions" here while the hunk above checks for a version with < 100000? If that check is written such that it covers all current versions, then it seems highly likely to break. If that's the case, can it be written more defensively? If it's not the case, aren't these contradictory?

Copy link
Contributor Author

@laffer1 laffer1 Oct 4, 2021

There is a catch all below this that catches all BSDs with a value of no. We don't want that. Every release of MidnightBSD supports a thread safe getaddrinfo as it was forked from FreeBSD 6.1.

Copy link
Contributor Author

@laffer1 laffer1 Oct 4, 2021

These aren't the same file and have different functionality.

bagder
bagder approved these changes Oct 5, 2021
@bagder
Copy link
Member

@bagder bagder commented Oct 5, 2021

Thanks!

@bagder bagder closed this in 18480f7 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants