Closed
Conversation
| tst_tsafe_getaddrinfo="yes" | ||
| ;; | ||
| midnightbsd*) | ||
| dnl all MidnightBSD versions |
Member
There was a problem hiding this comment.
Why does it say "all versions" here while the hunk above checks for a version with < 100000? If that check is written such that it covers all current versions, then it seems highly likely to break. If that's the case, can it be written more defensively? If it's not the case, aren't these contradictory?
Contributor
Author
There was a problem hiding this comment.
There is a catch all below this that catches all BSDs with a value of no. We don't want that. Every release of MidnightBSD supports a thread safe getaddrinfo as it was forked from FreeBSD 6.1.
Contributor
Author
There was a problem hiding this comment.
These aren't the same file and have different functionality.
bagder
approved these changes
Oct 5, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.