doh: remove experimental code for DoH with GET#7870
Closed
danielgustafsson wants to merge 1 commit intocurl:masterfrom
Closed
doh: remove experimental code for DoH with GET#7870danielgustafsson wants to merge 1 commit intocurl:masterfrom
danielgustafsson wants to merge 1 commit intocurl:masterfrom
Conversation
The code for sending DoH requests with GET was never enabled in a way such that it could be used or tested. As there haven't been requests for this feature, and since it at this is effectively dead, remove it and favor reimplementing the feature in case anyone is interested. Closes #xxxx
bagder
approved these changes
Oct 18, 2021
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Nice catch. I wholeheartedly agree!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for sending DoH requests with GET was never enabled in a way such that it could be used or tested. As there haven't been requests for this feature AFAICT, and since it at this is effectively dead, remove it and favor reimplementing the feature in case anyone is interested.