enable more tests for hyper #7889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns HYPERE_UNEXPECTED_EOF for this case which we convert to the somewhat generic CURLE_RECV_ERROR.
Follow-up to 823d3ab
This test verifies that curl works with binary zeroes in HTTP response headers and hyper refuses such. They're not kosher http.
bagder
force-pushed
the
bagder/hyper-tests
branch
from
467f47c
to
4c6e7db
Compare
Simply because hyper doesn't have this ability. Mentioned in docs now. Skip test 326 then
... and make sure to stop ignoring the body once the CONNECT is done. This should make test 206 work proper again and not be flaky.
bagder
added a commit
that referenced
this pull request
Oct 22, 2021
bagder
added a commit
that referenced
this pull request
Oct 22, 2021
This test verifies that curl works with binary zeroes in HTTP response headers and hyper refuses such. They're not kosher http. Closes #7889
bagder
added a commit
that referenced
this pull request
Oct 22, 2021
Simply because hyper doesn't have this ability. Mentioned in docs now. Skip test 326 then Closes #7889
bagder
added a commit
that referenced
this pull request
Oct 22, 2021
... and make sure to stop ignoring the body once the CONNECT is done. This should make test 206 work proper again and not be flaky. Closes #7889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.