configure.ac: replace krb5-config with pkg-config#7916
Closed
kanavin wants to merge 1 commit intocurl:masterfrom
Closed
configure.ac: replace krb5-config with pkg-config#7916kanavin wants to merge 1 commit intocurl:masterfrom
kanavin wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
reviewed
Oct 28, 2021
Member
There was a problem hiding this comment.
I think you should check how CURL_CHECK_PKGCONFIG is used for other components and use that method for pkg-config detection.
The rationale is that custom *-config tools don't work well when cross-compiling or using sysroots (such as when using Yocto project) and require custom fixing for each of them; pkg-config on the other hand works similarly everywhere. Signed-off-by: Roy Li <rongqing.li@windriver.com> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
kanavin
force-pushed
the
use-pkgconfig
branch
from
c7bd1d7 to
3302ba0
Compare
bagder
approved these changes
Oct 28, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale is that custom *-config tools don't work well when cross-compiling or using
sysroots (such as when using Yocto project) and require custom fixing for each of them;
pkg-config on the other hand works similarly everywhere.