Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: replace krb5-config with pkg-config #7916

Closed
wants to merge 1 commit into from

Conversation

@kanavin
Copy link

@kanavin kanavin commented Oct 28, 2021

The rationale is that custom *-config tools don't work well when cross-compiling or using
sysroots (such as when using Yocto project) and require custom fixing for each of them;
pkg-config on the other hand works similarly everywhere.

configure.ac Outdated
@@ -1677,7 +1677,7 @@ AC_ARG_WITH(gssapi,
fi
])

: ${KRB5CONFIG:="$GSSAPI_ROOT/bin/krb5-config"}
KRB5CONFIG=`which pkg-config`
Copy link
Member

@bagder bagder Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should check how CURL_CHECK_PKGCONFIG is used for other components and use that method for pkg-config detection.

Loading

Copy link
Author

@kanavin kanavin Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check again.

Loading

The rationale is that custom *-config tools don't work well when cross-compiling or using
sysroots (such as when using Yocto project) and require custom fixing for each of them;
pkg-config on the other hand works similarly everywhere.

Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
bagder
bagder approved these changes Oct 28, 2021
@bagder bagder closed this in 6fe4e7d Oct 28, 2021
@bagder
Copy link
Member

@bagder bagder commented Oct 28, 2021

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants