check the return value of curl_url() #7917

x2018 · 2021-10-28T12:04:25Z

curl_url() [lib/url.c:2396] is a memory allocation function, however, the return value of it is not properly checked.
Though curl_url_set() [lib/url.c:2402] checks it and then returns CURLUE_BAD_HANDLE, this will still confuse the proper result of parse_proxy().

bagder

I agree that this is nicer

bagder · 2021-10-28T13:23:22Z

Thanks!

check the return value of curl_url()

8063f1c

bagder approved these changes Oct 28, 2021

View changes

bagder closed this in d55b8b6 Oct 28, 2021

github-actions bot added the hacktoberfest-accepted label Oct 28, 2021

check the return value of curl_url() #7917

check the return value of curl_url() #7917

x2018 commented Oct 28, 2021

bagder left a comment

bagder commented Oct 28, 2021

check the return value of curl_url() #7917

check the return value of curl_url() #7917

Conversation

x2018 commented Oct 28, 2021

bagder left a comment

Choose a reason for hiding this comment

bagder commented Oct 28, 2021