Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_operate: don't make a failed etag save a fatal error #7945

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Nov 2, 2021

When failing to create the output file for saving an etag, only fail
that particular single transfer and allow others to follow.

In a serial transfer setup, if no transfer at all is done due to them
all being skipped because of this error, curl will output an error
message and return exit code 26.

Reported-by: Earnestly on github
Ref: #7942

When failing to create the output file for saving an etag, only fail
that particular single transfer and allow others to follow.

In a serial transfer setup, if no transfer at all is done due to them
all being skipped because of this error, curl will output an error
message and return exit code 26.

Added test 369 and 370 to verify.

Reported-by: Earnestly on github
Ref: #7942
Closes #7945
@bagder bagder force-pushed the bagder/etag-save-fail branch from 89c8005 to af98afe Nov 3, 2021
@bagder bagder closed this in cc71d35 Nov 4, 2021
@bagder bagder deleted the bagder/etag-save-fail branch Nov 4, 2021
@dfandrich
Copy link
Collaborator

@dfandrich dfandrich commented Nov 5, 2021

Looks like this change is causing torture test failures in tests 343 344 345 347,

Loading

@bagder
Copy link
Member Author

@bagder bagder commented Nov 5, 2021

Thanks, will fix!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants