Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add Schannel-specific tests or disable unsupported ones #7968

Closed
wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

@mback2k mback2k commented Nov 5, 2021

Adds Schannel variants of SSLpinning tests that include the option
--ssl-revoke-best-effort to ignore certificate revocation check
failures which is required due to our custom test CA certificate.

Disable the original variants if the Schannel backend is enabled.

Also skip all IDN tests which are broken while using an msys shell.

This is a step to simplify test exclusions for Windows and MinGW.

@mback2k mback2k self-assigned this Nov 5, 2021
@mback2k mback2k force-pushed the fix-schannel-tests branch 2 times, most recently from 3543fc6 to 157cc37 Nov 6, 2021
Adds Schannel variants of SSLpinning tests that include the option
--ssl-revoke-best-effort to ignore certificate revocation check
failures which is required due to our custom test CA certificate.

Disable the original variants if the Schannel backend is enabled.

Also skip all IDN tests which are broken while using an msys shell.

This is a step to simplify test exclusions for Windows and MinGW.
@mback2k mback2k force-pushed the fix-schannel-tests branch from 157cc37 to 6aeae37 Nov 6, 2021
@mback2k mback2k changed the title tests: add Schannel-specific tests or disabled unsupported ones tests: add Schannel-specific tests or disable unsupported ones Nov 7, 2021
@mback2k mback2k marked this pull request as ready for review Nov 7, 2021
@mback2k mback2k requested review from bagder, jay and MarcelRaad Nov 7, 2021
@jay
Copy link
Member

@jay jay commented Nov 7, 2021

Works for me. Why did you add quotes to the tests field?

Loading

@mback2k
Copy link
Member Author

@mback2k mback2k commented Nov 8, 2021

Because a leading ! without " has special meaning in YAML.

Loading

jay
jay approved these changes Nov 8, 2021
@mback2k
Copy link
Member Author

@mback2k mback2k commented Nov 8, 2021

Thanks guys. @bagder Do you think this can go in before the release or should I rather wait with this?

Loading

bagder
bagder approved these changes Nov 8, 2021
@bagder
Copy link
Member

@bagder bagder commented Nov 8, 2021

I think they can go in before the release.

Loading

mback2k added a commit to mback2k/curl that referenced this issue Nov 8, 2021
Adds Schannel variants of SSLpinning tests that include the option
--ssl-revoke-best-effort to ignore certificate revocation check
failures which is required due to our custom test CA certificate.

Disable the original variants if the Schannel backend is enabled.

Also skip all IDN tests which are broken while using an msys shell.

This is a step to simplify test exclusions for Windows and MinGW.

Reviewed-by: Jay Satiro
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg
Closes curl#7968
@mback2k
Copy link
Member Author

@mback2k mback2k commented Nov 8, 2021

@bagder unfortunately it seems like I am no longer allowed to push to master, not sure what changed though:
image

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.
To git@github.com:curl/curl.git
 ! [remote rejected] master -> master (protected branch hook declined)

Loading

@bagder
Copy link
Member

@bagder bagder commented Nov 8, 2021

Sorry, that was me experimenting with a feature that I shouldn't have. Hopefully fixed now.

Loading

@mback2k mback2k closed this in b3e1ed3 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants