Skip to content

http: add CURLINFO_HTTP_VERSION and %{http_version} - #799

Closed
gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:http_version
Closed

gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:http_version

Conversation

@gevaerts

Copy link
Copy Markdown
Contributor

Adds access to the effectively used http version to both libcurl and curl.

Initial attempt, almost certainly not final yet.

@jay

jay commented May 11, 2016 •

Copy link
Copy Markdown
Member

I like this idea, I have read of it a few times, as recently as last month. What do you think about using the existing CURL_HTTP_VERSION_X_X enumerations for getinfo, and then for the tool something like:

verstring = ((ver == CURL_HTTP_VERSION_2_0) ? "2.0" :
             (ver == CURL_HTTP_VERSION_1_1) ? "1.1" :
             (ver == CURL_HTTP_VERSION_1_0) ? "1.0" : "0");

@gevaerts

Copy link
Copy Markdown
Contributor Author

I've updated the patch to use CURL_HTTP_VERSION now.

@bagder bagder added the HTTP label May 11, 2016
@bagder

bagder commented May 11, 2016

Copy link
Copy Markdown
Member

👍 to merge first thing after the pending release

@bagder

bagder commented May 17, 2016

Copy link
Copy Markdown
Member

Note that the travis-ci test failure is because the new symbol is not properly added to docs/libcurl/symbols-in-versions

@gevaerts

Copy link
Copy Markdown
Contributor Author

I've added it to symbols-in-versions now.

@bagder

bagder commented May 19, 2016

Copy link
Copy Markdown
Member

Ganesh Nikam just posted a version of this patch on the mailing list:

https://curl.haxx.se/mail/lib-2016-05/0131.html

He included a little example in his man page that could be merged into this patch to make it perfect I think!

Comment thread src/tool_writeout.c Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the string "2.0" would be better here instead of "2".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus seems to be that it's http 2, not 2.0. See e.g. https://http2.github.io/faq/#is-it-http20-or-http2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol is named HTTP/2 and there's no ".0" in the name or the version. I think we avoid a lot of problems by sticking to the official name.

Adds access to the effectively used http version to both libcurl and curl.
@bagder bagder closed this in 071c561 May 30, 2016
@gevaerts
gevaerts deleted the http_version branch December 21, 2016 15:01
@lock lock Bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants