New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: add CURLINFO_HTTP_VERSION and %{http_version} #799

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@gevaerts
Contributor

gevaerts commented May 11, 2016

Adds access to the effectively used http version to both libcurl and curl.

Initial attempt, almost certainly not final yet.

@jay

This comment has been minimized.

Member

jay commented May 11, 2016

I like this idea, I have read of it a few times, as recently as last month. What do you think about using the existing CURL_HTTP_VERSION_X_X enumerations for getinfo, and then for the tool something like:

verstring = ((ver == CURL_HTTP_VERSION_2_0) ? "2.0" :
             (ver == CURL_HTTP_VERSION_1_1) ? "1.1" :
             (ver == CURL_HTTP_VERSION_1_0) ? "1.0" : "0");

@gevaerts gevaerts force-pushed the gevaerts:http_version branch from 26487b8 to 965d676 May 11, 2016

@gevaerts

This comment has been minimized.

Contributor

gevaerts commented May 11, 2016

I've updated the patch to use CURL_HTTP_VERSION now.

@bagder bagder added the HTTP label May 11, 2016

@bagder

This comment has been minimized.

Member

bagder commented May 11, 2016

👍 to merge first thing after the pending release

@bagder

This comment has been minimized.

Member

bagder commented May 17, 2016

Note that the travis-ci test failure is because the new symbol is not properly added to docs/libcurl/symbols-in-versions

@gevaerts gevaerts force-pushed the gevaerts:http_version branch from 965d676 to 91f7d6a May 17, 2016

@gevaerts

This comment has been minimized.

Contributor

gevaerts commented May 17, 2016

I've added it to symbols-in-versions now.

@gevaerts gevaerts force-pushed the gevaerts:http_version branch from 91f7d6a to e28a590 May 17, 2016

@bagder

This comment has been minimized.

Member

bagder commented May 19, 2016

Ganesh Nikam just posted a version of this patch on the mailing list:

https://curl.haxx.se/mail/lib-2016-05/0131.html

He included a little example in his man page that could be merged into this patch to make it perfect I think!

version = "1.1";
break;
case CURL_HTTP_VERSION_2_0:
version = "2";

This comment has been minimized.

@ganeshnikam18

ganeshnikam18 May 19, 2016

I think the string "2.0" would be better here instead of "2".

This comment has been minimized.

@gevaerts

gevaerts May 19, 2016

Contributor

The consensus seems to be that it's http 2, not 2.0. See e.g. https://http2.github.io/faq/#is-it-http20-or-http2

This comment has been minimized.

@bagder

bagder May 19, 2016

Member

The protocol is named HTTP/2 and there's no ".0" in the name or the version. I think we avoid a lot of problems by sticking to the official name.

http: add CURLINFO_HTTP_VERSION and %{http_version}
Adds access to the effectively used http version to both libcurl and curl.

@gevaerts gevaerts force-pushed the gevaerts:http_version branch from e28a590 to 7e4ae76 May 19, 2016

@bagder bagder closed this in 071c561 May 30, 2016

@gevaerts gevaerts deleted the gevaerts:http_version branch Dec 21, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.