Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for disabling certificate validation on OS X 10.8 (Mountain Lion) #802

Closed
wants to merge 3 commits into from

Conversation

@PerMalmberg
Copy link
Contributor

commented May 12, 2016

This is pull request for the problem I asked about on the mailing list.

I stumbled on this old patch from 2012 which is similar to my issue, but not quite the same. Some further digging and testing has reviled that the issue also exists on OS X 10.8. I've tested these changes on 10.7.5, 10.8, 10.9, 10.10.2 and 10.11 and am able to enable/disable CURLOPT_SSL_VERIFYPEER on all of these version with this change.

Cheers,

Per

PerMalmberg added 3 commits May 12, 2016
The new way of disabling certificate verification doesn't work on Mou…
…ntain Lion (OS X 10.8) so we need to use the old way in that version too.

I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2 and 10.11.
@bagder

This comment has been minimized.

Copy link
Member

commented May 12, 2016

Tip: make checksrc runs the source code checks for you...

@bagder bagder closed this in 3cf3399 May 12, 2016

@bagder

This comment has been minimized.

Copy link
Member

commented May 12, 2016

thanks! (I merged them as a single squashed commit)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.