Fix for disabling certificate validation on OS X 10.8 (Mountain Lion) #802

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@PerMalmberg
Contributor

This is pull request for the problem I asked about on the mailing list.

I stumbled on this old patch from 2012 which is similar to my issue, but not quite the same. Some further digging and testing has reviled that the issue also exists on OS X 10.8. I've tested these changes on 10.7.5, 10.8, 10.9, 10.10.2 and 10.11 and am able to enable/disable CURLOPT_SSL_VERIFYPEER on all of these version with this change.

Cheers,

Per

PerMalmberg added some commits May 12, 2016
@PerMalmberg PerMalmberg The new way of disabling certificate verification doesn't work on Mou…
…ntain Lion (OS X 10.8) so we need to use the old way in that version too.

I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2 and 10.11.
9dd92d3
@PerMalmberg PerMalmberg Fixed formatting to make travis-ci happy.
3b61f8f
@PerMalmberg PerMalmberg Travis-ci, again. Wish I knew how to run these checks locally before …
…commit. :)
5978016
@bagder
Member
bagder commented May 12, 2016

Tip: make checksrc runs the source code checks for you...

@bagder bagder added a commit that closed this pull request May 12, 2016
@PerMalmberg @bagder PerMalmberg + bagder darwinssl: fix certificate verification disable on OS X 10.8
The new way of disabling certificate verification doesn't work on
Mountain Lion (OS X 10.8) so we need to use the old way in that version
too. I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2
and 10.11.

Closes #802
3cf3399
@bagder bagder closed this in 3cf3399 May 12, 2016
@bagder
Member
bagder commented May 12, 2016

thanks! (I merged them as a single squashed commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment