Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rustls comment about checking handshaking #8038

Closed
wants to merge 1 commit into from

Conversation

@jsha
Copy link
Contributor

@jsha jsha commented Nov 19, 2021

The comment is incorrect in two ways:

  • It says the check needs to be last, but the check is actually first.
  • is_handshaking actually starts out true.

Prompted by rustls/rustls-ffi#134.

The comment is incorrect in two ways:
 - It says the check needs to be last, but the check is actually first.
 - is_handshaking actually starts out true.
bagder
bagder approved these changes Nov 20, 2021
@bagder
Copy link
Member

@bagder bagder commented Nov 20, 2021

Thanks!

Loading

@bagder bagder closed this in 3f8fde3 Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants