Makefile.m32: rename -winssl option to -schannel and tidy up#8053
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
Makefile.m32: rename -winssl option to -schannel and tidy up#8053vszakats wants to merge 3 commits intocurl:masterfrom
vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
Which is the same as the existing -winssl CFG option. This marks -winssl deprecated.
By altering the condition a little bit and to avoid repeating the option names.
vszakats
changed the title
vszakats
changed the title
MarcelRaad
approved these changes
Nov 25, 2021
bagder
approved these changes
Nov 25, 2021
Member
Author
|
Thanks for the reviews, merged. Test build: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/41669517 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-schannelas an alternative toCFGoption-winssl. (Latter is still accepted, but deprecated)WINSSLtoSCHANNELCFGoption evaluation shorter, without repeating the option nameLet me know if dropping the previous,
-winssloption name would be desirable/acceptable.