Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: rename -winssl option to -schannel and tidy up #8053

Closed
wants to merge 3 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Nov 24, 2021

  • Accept -schannel as an alternative to CFG option -winssl. (Latter is still accepted, but deprecated)
  • Rename internal variable WINSSL to SCHANNEL
  • Make the CFG option evaluation shorter, without repeating the option name

Let me know if dropping the previous, -winssl option name would be desirable/acceptable.

vszakats added 3 commits Nov 24, 2021
Which is the same as the existing -winssl CFG option.
This marks -winssl deprecated.
By altering the condition a little bit and to avoid repeating the
option names.
@vszakats vszakats changed the title Makefile.m32: Replace -winssl option with -schannel and tidy up Makefile.m32: replace -winssl option with -schannel and tidy up Nov 24, 2021
@vszakats vszakats changed the title Makefile.m32: replace -winssl option with -schannel and tidy up Makefile.m32: rename -winssl option to -schannel and tidy up Nov 24, 2021
@vszakats vszakats added build tidy-up Windows labels Nov 24, 2021
bagder
bagder approved these changes Nov 25, 2021
@vszakats vszakats closed this in 8c0336c Nov 25, 2021
@vszakats
Copy link
Member Author

@vszakats vszakats commented Nov 25, 2021

Thanks for the reviews, merged. Test build: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/41669517

@vszakats vszakats deleted the m32sch branch Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants