hash: lazy-alloc the table in Curl_hash_add() #8132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Curl_hash_init() infallible which saves error paths. Closes #8132
bagder
force-pushed
the
bagder/hash-lazyalloc
branch
from
acd3638
to
254f7bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Curl_hash_init() infallible which saves error paths.
It also reduces the number of mallocs needed for basic use cases. My test runs doing
curl -v localhost/512M -o /dev/nullgoes from 94 mallocs to 91. With a maximum 132510 bytes down to 132158 (= 352 bytes less).