Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openldap: some tiny adjustments

Closed
wants to merge 1 commit into from
Closed

Conversation

monnerat
Copy link
Contributor

@monnerat monnerat commented Dec 13, 2021

  • Early check proper LDAP URL syntax. Reject URLs with a userinfo part.
  • Use dynamic memory for ldap_init_fd() URL rather than a
    stack-allocated buffer.
  • Never chase referrals: supporting it would require additional parallel
    connections and alternate authentication credentials.
  • Do not wait 1 microsecond while polling/reading query response data.
  • Store last received server code for retrieval with CURLINFO_RESPONSE_CODE.

Maybe you will postpone pull of this as CURLINFO_RESPONSE_CODE for LDAP might be considered as a feature.

@monnerat monnerat marked this pull request as draft Dec 13, 2021
@monnerat monnerat marked this pull request as ready for review Dec 14, 2021
docs/libcurl/opts/CURLINFO_RESPONSE_CODE.3 Outdated Show resolved Hide resolved
lib/openldap.c Outdated Show resolved Hide resolved
@bagder bagder added the LDAP label Dec 14, 2021
- Early check proper LDAP URL syntax. Reject URLs with a userinfo part.
- Use dynamic memory for ldap_init_fd() URL rather than a
  stack-allocated buffer.
- Never chase referrals: supporting it would require additional parallel
  connections and alternate authentication credentials.
- Do not wait 1 microsecond while polling/reading query response data.
- Store last received server code for retrieval with CURLINFO_RESPONSE_CODE.
bagder
bagder approved these changes Dec 14, 2021
@bagder
Copy link
Member

bagder commented Dec 15, 2021

Thanks!

@bagder bagder closed this in cdc1da9 Dec 15, 2021
@monnerat
Copy link
Contributor Author

monnerat commented Dec 15, 2021

Thanks for pulling!

@monnerat monnerat deleted the ldap-5 branch Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants