Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check ssl_config when re-use TLS proxy connection

Merged
merged 1 commit into from Dec 14, 2021

Conversation

MrDwZ
Copy link
Contributor

@MrDwZ MrDwZ commented Dec 14, 2021

Hi!

I'm following up this mail list thread, ssl_config need to be checked even when proxy_ssl_config is presented. Otherwise the destination TLS connections under the same hostname could mess up when re-use a connection and HTTPs proxy is presented with TLS-over-TLS.

I tested against some of our internal integration tests with HTTPS proxy without any issue, will see how the CI goes here.

@MrDwZ MrDwZ changed the title check ssl_config when re-use proxy connection check ssl_config when re-use TLS proxy connection Dec 14, 2021
bagder
bagder approved these changes Dec 14, 2021
@bagder bagder merged commit 1cdfdcd into curl:master Dec 14, 2021
44 of 48 checks passed
@bagder
Copy link
Member

bagder commented Dec 14, 2021

Sorry everyone, I merged that the wrong way with the wrong commit message.

bagder added a commit that referenced this issue Dec 14, 2021
@bagder
Copy link
Member

bagder commented Dec 14, 2021

Thanks @MrDwZ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants