Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Fix CURLOPT_HTTP200ALIASES #8171

Closed
wants to merge 2 commits into from
Closed

Conversation

@CyberShadow
Copy link
Contributor

@CyberShadow CyberShadow commented Dec 20, 2021

The httpcode < 100 check was also triggered when none of the fields were parsed, thus making the if(!nc) block unreachable.

Regression introduced in c67a32f.

The httpcode < 100 check was also triggered when none of the fields
were parsed, thus making the if(!nc) block unreachable.
bagder
bagder approved these changes Dec 21, 2021
@bagder
Copy link
Member

@bagder bagder commented Dec 21, 2021

Seems likely that c67a32f broke this.

@bagder
Copy link
Member

@bagder bagder commented Dec 21, 2021

Extra bonus points for the excellent added test! 💯

@bagder
Copy link
Member

@bagder bagder commented Dec 21, 2021

Thanks!

@bagder bagder closed this in 1b9f1f6 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants