Skip to content

ngtcp2: verify the server cert on connect - #8178

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/http3-ngtcp2-cacert
Closed

bagder wants to merge 2 commits into
masterfrom
bagder/http3-ngtcp2-cacert

Conversation

@bagder

@bagder bagder commented Dec 23, 2021 •

Copy link
Copy Markdown
Member

This makes ngtcp2+quictls acknowledge CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST

  • ngtcp2 + quictls
  • ngtcp2 + gnutls
  • quiche

Ref: #8173

@bagder bagder added the HTTP/3 h3 or quic related label Dec 23, 2021
@bagder

bagder commented Dec 23, 2021

Copy link
Copy Markdown
Member Author

Since quiche uses boringssl, it can probably be possible to use more or less the same code there, and possibly we can write the generic openssl certificate check code to be usable in all three places, but as a first shot the functionality should get there and only later I'll work on combining code.

Make ngtcp2+quictls correctly acknowledge `CURLOPT_SSL_VERIFYPEER` and
`CURLOPT_SSL_VERIFYHOST`.

The name check now uses a function from lib/vtls/openssl.c which will
need attention for when TLS is not done by OpenSSL or is disabled while
QUIC is enabled.

Possibly the servercert() function in openssl.c should be adjusted to be
able to use for both regular TLS and QUIC.

Ref: #8173
@bagder
bagder force-pushed the bagder/http3-ngtcp2-cacert branch from 0ed45a6 to 08bcfd8 Compare December 25, 2021 20:54
@bagder bagder closed this in c148f0f Dec 28, 2021
bagder added a commit that referenced this pull request Dec 28, 2021
@bagder
bagder deleted the bagder/http3-ngtcp2-cacert branch January 4, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

1 participant