New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: add CURLOPT_CERTINFO support #822

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@ajax16384
Copy link
Contributor

ajax16384 commented May 20, 2016

allow to retrieve certinfo from winssl backend

ajax16384 added some commits May 20, 2016

@@ -578,6 +578,7 @@ if(NOT UNIX)
if(HAVE_SCHANNEL_H)
set(USE_SCHANNEL ON)
set(SSL_ENABLED ON)
check_library_exists_concat("crypt32" CertFreeCertificateContext HAVE_LIBCRYPT32)

This comment has been minimized.

@mback2k

mback2k May 27, 2016

Member

Please fix the indentation by adding one additional space in front of this line.

This comment has been minimized.

@ajax16384

ajax16384 May 27, 2016

Author Contributor

ok

result = Curl_ssl_init_certinfo(data, 1);
if(!result) {
if(((ccert_context->dwCertEncodingType & X509_ASN_ENCODING) != 0) &&
(ccert_context->cbCertEncoded > 0)) {

This comment has been minimized.

@mback2k

mback2k May 27, 2016

Member

Please fix the indentation by adding one additional space in front of this line.

This comment has been minimized.

@ajax16384

ajax16384 May 27, 2016

Author Contributor

ok

@mback2k

This comment has been minimized.

Copy link
Member

mback2k commented May 27, 2016

The proposed patch / merge request looks good to me, aside from the small indentation fixes. @bagder do you have any final comments before merging?

@jay

This comment has been minimized.

Copy link
Member

jay commented May 27, 2016

@mback2k hold off there's a patch release pending that's why no features have been added

@mback2k

This comment has been minimized.

Copy link
Member

mback2k commented May 27, 2016

@jay Yep, I saw that information. :-)

Andrei Kurushin
@bagder

This comment has been minimized.

Copy link
Member

bagder commented May 30, 2016

my comment: 👍

@bagder bagder added the SSL/TLS label Jun 1, 2016

@bagder bagder closed this in 6cabd78 Jun 1, 2016

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 1, 2016

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.