Skip to content

schannel: add CURLOPT_CERTINFO support#822

Closed
ajax16384 wants to merge 4 commits intocurl:masterfrom
ajax16384:master
Closed

schannel: add CURLOPT_CERTINFO support#822
ajax16384 wants to merge 4 commits intocurl:masterfrom
ajax16384:master

Conversation

@ajax16384
Copy link
Copy Markdown
Contributor

@ajax16384 ajax16384 commented May 20, 2016

allow to retrieve certinfo from winssl backend

Comment thread CMakeLists.txt Outdated
if(HAVE_SCHANNEL_H)
set(USE_SCHANNEL ON)
set(SSL_ENABLED ON)
check_library_exists_concat("crypt32" CertFreeCertificateContext HAVE_LIBCRYPT32)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation by adding one additional space in front of this line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mback2k
Copy link
Copy Markdown
Member

mback2k commented May 27, 2016

The proposed patch / merge request looks good to me, aside from the small indentation fixes. @bagder do you have any final comments before merging?

@jay
Copy link
Copy Markdown
Member

jay commented May 27, 2016

@mback2k hold off there's a patch release pending that's why no features have been added

@mback2k
Copy link
Copy Markdown
Member

mback2k commented May 27, 2016

@jay Yep, I saw that information. :-)

@bagder
Copy link
Copy Markdown
Member

bagder commented May 30, 2016

my comment: 👍

@bagder bagder added the TLS label Jun 1, 2016
@bagder bagder closed this in 6cabd78 Jun 1, 2016
@bagder
Copy link
Copy Markdown
Member

bagder commented Jun 1, 2016

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants