schannel: add CURLOPT_CERTINFO support #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -578,6 +578,7 @@ if(NOT UNIX) | |||
| if(HAVE_SCHANNEL_H) | |||
| set(USE_SCHANNEL ON) | |||
| set(SSL_ENABLED ON) | |||
| check_library_exists_concat("crypt32" CertFreeCertificateContext HAVE_LIBCRYPT32) | |||
There was a problem hiding this comment.
Please fix the indentation by adding one additional space in front of this line.
|
The proposed patch / merge request looks good to me, aside from the small indentation fixes. @bagder do you have any final comments before merging? |
|
@mback2k hold off there's a patch release pending that's why no features have been added |
|
@jay Yep, I saw that information. :-) |
|
my comment: |
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
allow to retrieve certinfo from winssl backend