Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: add CURLOPT_CERTINFO support #822

Closed
wants to merge 4 commits into from
Closed

schannel: add CURLOPT_CERTINFO support #822

wants to merge 4 commits into from

Conversation

@ajax16384
Copy link
Contributor

@ajax16384 ajax16384 commented May 20, 2016

allow to retrieve certinfo from winssl backend

@@ -578,6 +578,7 @@ if(NOT UNIX)
if(HAVE_SCHANNEL_H)
set(USE_SCHANNEL ON)
set(SSL_ENABLED ON)
check_library_exists_concat("crypt32" CertFreeCertificateContext HAVE_LIBCRYPT32)
Copy link
Member

@mback2k mback2k May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation by adding one additional space in front of this line.

Loading

Copy link
Contributor Author

@ajax16384 ajax16384 May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Loading

@mback2k
Copy link
Member

@mback2k mback2k commented May 27, 2016

The proposed patch / merge request looks good to me, aside from the small indentation fixes. @bagder do you have any final comments before merging?

Loading

@jay
Copy link
Member

@jay jay commented May 27, 2016

@mback2k hold off there's a patch release pending that's why no features have been added

Loading

@mback2k
Copy link
Member

@mback2k mback2k commented May 27, 2016

@jay Yep, I saw that information. :-)

Loading

@bagder
Copy link
Member

@bagder bagder commented May 30, 2016

my comment: 👍

Loading

@bagder bagder added the TLS label Jun 1, 2016
@bagder bagder closed this in 6cabd78 Jun 1, 2016
@bagder
Copy link
Member

@bagder bagder commented Jun 1, 2016

thanks!

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants