Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the nonewline attribute in data section of tests #8239

Closed
wants to merge 4 commits into from

Conversation

@fabiankeil
Copy link
Contributor

@fabiankeil fabiankeil commented Jan 7, 2022

Obviously curl doesn't care but I needed this for Privoxy tests
(for example to test gif deanimation).

@bagder bagder added the tests label Jan 7, 2022
@fabiankeil
Copy link
Contributor Author

@fabiankeil fabiankeil commented Jan 8, 2022

Unfortunately I haven't figured out yet how to download the log files for failed test runs to properly investigate them (and maybe GitHub doesn't even support this) but my impression after partially viewing the logs in the browser is that the failures I saw are unrelated to my changes.

@bagder
Copy link
Member

@bagder bagder commented Jan 9, 2022

I think those test failures are unrelated. Can you rebase and force-push to get a new run with some recent changes in?

@bagder bagder closed this in 7368476 Jan 10, 2022
bagder added a commit that referenced this issue Jan 10, 2022
@bagder
Copy link
Member

@bagder bagder commented Jan 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants