Support the nonewline attribute in data section of tests #8239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I haven't figured out yet how to download the log files for failed test runs to properly investigate them (and maybe GitHub doesn't even support this) but my impression after partially viewing the logs in the browser is that the failures I saw are unrelated to my changes. |
|
I think those test failures are unrelated. Can you rebase and force-push to get a new run with some recent changes in? |
fabiankeil
force-pushed
the
nonewline-data
branch
from
220b469
to
c316ca7
Compare
bagder
pushed a commit
that referenced
this pull request
Jan 10, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Obviously curl doesn't care but I needed this for Privoxy tests
(for example to test gif deanimation).