Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_multi_socket.3: remove callback and typical usage descriptions #8262

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 11, 2022

  1. The callback is better described in the option for setting it. Having
    it in a single place reduces the risk that one of them is wrong.

  2. The "typical usage" is wrong since the functions described in this
    man page are both deprecated so they cannot be used in any "typical" way
    anymore.

1. The callback is better described in the option for setting it. Having
it in a single place reduces the risk that one of them is wrong.

2. The "typical usage" is wrong since the functions described in this
man page are both deprecated so they cannot be used in any "typical" way
anymore.
The \fIaction\fP argument to the callback has one of five values:
.RS
.IP "CURL_POLL_NONE (0)"
register, not interested in readiness (yet)
Copy link
Member

@jay jay Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note CURL_POLL_NONE is not mentioned in CURLMOPT_SOCKETFUNCTION

Copy link
Member Author

@bagder bagder Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that proves my point... 😁

Looking at the code, I don't think CURL_POLL_NONE can actually be passed to the callback so I think it is correct to not document it as such.

@bagder bagder closed this in cb0c797 Jan 12, 2022
@bagder bagder deleted the bagder/curl_multi_socket.3 branch Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants