Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: make Curl_disconnect return void #8303

Closed
wants to merge 2 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 19, 2022

  1. The function would only ever return CURLE_OK anyway
  2. Only one caller actually used the return code
  3. Most callers did (void)Curl_disconnect()

 1. The function would only ever return CURLE_OK anyway
 2. Only one caller actually used the return code
 3. Most callers did (void)Curl_disconnect()
@bagder bagder added the tidy-up label Jan 19, 2022
Copy link
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise ok

lib/url.c Show resolved Hide resolved
@bagder bagder closed this in e74a6b7 Jan 20, 2022
@bagder bagder deleted the bagder/void-disconnect branch Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants