Change qlog file extension to .sqlog#8316
Closed
LPardue wants to merge 1 commit into
Closed
Conversation
quiche has just switched it's qlog serialization format to JSON-SEQ by default . The spec says this SHOULD use `.sqlog` extension. I believe ngtcp2 also supports JSON-SEQ by default as of ngtcp2/ngtcp2@9baf06f Let's update curl so that tools know what format we are using!
bagder
approved these changes
Jan 21, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quiche has just switched it's qlog serialization format to JSON-SEQ by default . The spec says this SHOULD use
.sqlogextension.I believe ngtcp2 also supports JSON-SEQ by default as of ngtcp2/ngtcp2@9baf06f
Let's update curl so that tools know what format we are using!