configure: set CURL_LIBRARY_PATH for nghttp2#8340
Closed
bwncp wants to merge 1 commit into
Closed
Conversation
bagder
requested changes
Jan 27, 2022
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
Setting the variable seems like the right change indeed, but I think it should be done slightly further down, in the code block where USE_NGHTTP2 is set. Because otherwise you might have it set before it is confirmed to be the right version.
bwncp
force-pushed
the
h2-library-path
branch
from
2a0c156 to
c0ebda5
Compare
Contributor
Author
Thanks for your feedback. Fixed now. |
To execute the test program, we might need the library path so that the lib is found at runtime.
bwncp
force-pushed
the
h2-library-path
branch
from
c0ebda5 to
3271796
Compare
bagder
approved these changes
Jan 28, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To execute the test program, we might need the library path so that the lib is found at runtime.