Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: set CURL_LIBRARY_PATH for nghttp2 #8340

Closed
wants to merge 1 commit into from

Conversation

bwncp
Copy link
Contributor

@bwncp bwncp commented Jan 27, 2022

To execute the test program, we might need the library path so that the lib is found at runtime.

Copy link
Member

@bagder bagder left a comment

Setting the variable seems like the right change indeed, but I think it should be done slightly further down, in the code block where USE_NGHTTP2 is set. Because otherwise you might have it set before it is confirmed to be the right version.

@bwncp
Copy link
Contributor Author

@bwncp bwncp commented Jan 28, 2022

Setting the variable seems like the right change indeed, but I think it should be done slightly further down, in the code block where USE_NGHTTP2 is set. Because otherwise you might have it set before it is confirmed to be the right version.

Thanks for your feedback.

Fixed now.

@bwncp bwncp requested a review from bagder Jan 28, 2022
@bwncp bwncp marked this pull request as draft Jan 28, 2022
To execute the test program, we might need the library path so that the lib
is found at runtime.
@bwncp bwncp marked this pull request as ready for review Jan 28, 2022
bagder
bagder approved these changes Jan 28, 2022
@bagder
Copy link
Member

@bagder bagder commented Jan 28, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants