Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix ngtcp2 crypto library detection #8372

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Feb 1, 2022

  • Change library link check for ngtcp2_crypto_{gnutls,openssl} to
    to use function ngtcp2_crypto_recv_client_initial_cb instead of
    ngtcp2_crypto_ctx_initial.

The latter function is no longer external since two days ago in
ngtcp2/ngtcp2@533451f. curl HTTP/3 CI builds have been failing since
then because they would not link to the ngtcp2 crypto library.

Ref: ngtcp2/ngtcp2#356

Closes #xxxx


See this zuul build of curl-novalgrind-ngtcp2-gnutls for example:

  CCLD     curl
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_recv_retry_cb'
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_recv_crypto_data_cb'
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_decrypt_cb'
...and so on

/cc @tatsuhiro-t

- Change library link check for ngtcp2_crypto_{gnutls,openssl} to
  to use function ngtcp2_crypto_recv_client_initial_cb instead of
  ngtcp2_crypto_ctx_initial.

The latter function is no longer external since two days ago in
ngtcp2/ngtcp2@533451f. curl HTTP/3 CI builds have been failing since
then because they would not link to the ngtcp2 crypto library.

Ref: ngtcp2/ngtcp2#356

Closes #xxxx
@jay jay added HTTP/3 CI labels Feb 1, 2022
@bagder
Copy link
Member

@bagder bagder commented Feb 1, 2022

#7522 is truly annoying...

@jay jay deleted the ngtcp2_crypto_lib_check branch Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI HTTP/3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants