Skip to content

build: fix ngtcp2 crypto library detection#8372

Closed
jay wants to merge 1 commit into
curl:masterfrom
jay:ngtcp2_crypto_lib_check
Closed

build: fix ngtcp2 crypto library detection#8372
jay wants to merge 1 commit into
curl:masterfrom
jay:ngtcp2_crypto_lib_check

Conversation

@jay

@jay jay commented Feb 1, 2022

Copy link
Copy Markdown
Member
  • Change library link check for ngtcp2_crypto_{gnutls,openssl} to
    to use function ngtcp2_crypto_recv_client_initial_cb instead of
    ngtcp2_crypto_ctx_initial.

The latter function is no longer external since two days ago in
ngtcp2/ngtcp2@533451f. curl HTTP/3 CI builds have been failing since
then because they would not link to the ngtcp2 crypto library.

Ref: ngtcp2/ngtcp2#356

Closes #xxxx


See this zuul build of curl-novalgrind-ngtcp2-gnutls for example:

  CCLD     curl
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_recv_retry_cb'
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_recv_crypto_data_cb'
../lib/.libs/libcurl.so: undefined reference to `ngtcp2_crypto_decrypt_cb'
...and so on

/cc @tatsuhiro-t

- Change library link check for ngtcp2_crypto_{gnutls,openssl} to
  to use function ngtcp2_crypto_recv_client_initial_cb instead of
  ngtcp2_crypto_ctx_initial.

The latter function is no longer external since two days ago in
ngtcp2/ngtcp2@533451f. curl HTTP/3 CI builds have been failing since
then because they would not link to the ngtcp2 crypto library.

Ref: ngtcp2/ngtcp2#356

Closes #xxxx
@jay jay added HTTP/3 h3 or quic related CI Continuous Integration labels Feb 1, 2022
@bagder

bagder commented Feb 1, 2022

Copy link
Copy Markdown
Member

#7522 is truly annoying...

@jay jay closed this in 7931287 Feb 2, 2022
@jay jay deleted the ngtcp2_crypto_lib_check branch February 2, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

3 participants