Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl-openssl: fix SRP check for OpenSSL 3.0 #8394

Closed
wants to merge 1 commit into from

Conversation

MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Feb 6, 2022

When OpenSSL 3.0 is built with --api=3.0 and no-deprecated, the SRP
functions exist in the library, but are disabled for user code. Check
if they are actually usable instead of only if they exist. Also check
for the functions actually required for TLS-SRP.

TLS-SRP support is still enabled if OpenSSL is configured with just
--api=3.0 or with --api=1.1.1 no-deprecated.

(I'm not very familiar with autoconf and m4 - please let me know if there's a better way to do that.)

When OpenSSL 3.0 is built with `--api=3.0` and `no-deprecated`, the SRP
functions exist in the library, but are disabled for user code. Check
if they are actually usable instead of only if they exist. Also check
for the functions actually required for TLS-SRP.

TLS-SRP support is still enabled if OpenSSL is configured with just
`--api=3.0` or with `--api=1.1.1 no-deprecated`.

Closes
bagder
bagder approved these changes Feb 7, 2022
Copy link
Member

@bagder bagder left a comment

Looks fine to me!

@MarcelRaad MarcelRaad deleted the fix_opensslv3_srp_check branch Feb 7, 2022
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Feb 7, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants