Skip to content

deprecate NSS support#8395

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/deprecate-NSS
Closed

deprecate NSS support#8395
bagder wants to merge 2 commits into
masterfrom
bagder/deprecate-NSS

Conversation

@bagder

@bagder bagder commented Feb 7, 2022

Copy link
Copy Markdown
Member

Add deprecation plans to docs/DEPRECATE.md

@bagder bagder changed the title configure: requires --with-nss-aware to build with NSS deprecate NSS support Feb 7, 2022
@danielgustafsson

Copy link
Copy Markdown
Member

Another option would be to add a --enable-deprecated flag and then require that along with --with-nss and other deprecated options. An opt-in to explicitly have to say "I know what I'm getting myself in to" and then we can use that same mechanism for gatekeeping other features on the way out?

@bagder

bagder commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

That's not a bad idea, but I have to say that I like that the way I did it here needs the user to acknowledge this exact feature being deprecated and not accepting deprecation in general.

@jay

jay commented Feb 7, 2022

Copy link
Copy Markdown
Member

this exact feature being deprecated and not accepting deprecation in general.

Well I'm with you on that but --with-nss-aware doesn't say much to an admin glancing through their company's shell scripts. --DEPRECATED-with-nss or something

@bagder

bagder commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

The flag name needs to start with --with for the configure option thing to work. --with-deprecated-nss perhaps?

@danielgustafsson

danielgustafsson commented Feb 8, 2022 via email

Copy link
Copy Markdown
Member

@jay

jay commented Feb 8, 2022

Copy link
Copy Markdown
Member

I agree, something with deprecated in the name.

Add deprecation plans to docs/DEPRECATE.md

Closes #8395
@bagder bagder force-pushed the bagder/deprecate-NSS branch from 1264363 to 2870e56 Compare February 9, 2022 08:24
@bagder

bagder commented Feb 9, 2022

Copy link
Copy Markdown
Member Author

Uses --with-nss-deprecated now!

@bagder bagder closed this in 3738de3 Feb 9, 2022
@bagder bagder deleted the bagder/deprecate-NSS branch February 9, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants