Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate NSS support #8395

Closed
wants to merge 2 commits into from
Closed

deprecate NSS support #8395

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 7, 2022

Add deprecation plans to docs/DEPRECATE.md

@bagder bagder changed the title configure: requires --with-nss-aware to build with NSS deprecate NSS support Feb 7, 2022
@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Feb 7, 2022

Another option would be to add a --enable-deprecated flag and then require that along with --with-nss and other deprecated options. An opt-in to explicitly have to say "I know what I'm getting myself in to" and then we can use that same mechanism for gatekeeping other features on the way out?

@bagder
Copy link
Member Author

@bagder bagder commented Feb 7, 2022

That's not a bad idea, but I have to say that I like that the way I did it here needs the user to acknowledge this exact feature being deprecated and not accepting deprecation in general.

@jay
Copy link
Member

@jay jay commented Feb 7, 2022

this exact feature being deprecated and not accepting deprecation in general.

Well I'm with you on that but --with-nss-aware doesn't say much to an admin glancing through their company's shell scripts. --DEPRECATED-with-nss or something

@bagder
Copy link
Member Author

@bagder bagder commented Feb 7, 2022

The flag name needs to start with --with for the configure option thing to work. --with-deprecated-nss perhaps?

@danielgustafsson
Copy link
Member

@danielgustafsson danielgustafsson commented Feb 8, 2022

@jay
Copy link
Member

@jay jay commented Feb 8, 2022

I agree, something with deprecated in the name.

Add deprecation plans to docs/DEPRECATE.md

Closes #8395
@bagder bagder force-pushed the bagder/deprecate-NSS branch from 1264363 to 2870e56 Compare Feb 9, 2022
@bagder
Copy link
Member Author

@bagder bagder commented Feb 9, 2022

Uses --with-nss-deprecated now!

@bagder bagder deleted the bagder/deprecate-NSS branch Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants