Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: when SSL_read() returns zero, check the error #8431

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 10, 2022

Returning zero typically indicates end of connection, so if there's no
data read but the connection is alive, it needs to return -1 with
CURLE_AGAIN.

@bagder bagder added the TLS label Feb 10, 2022
Copy link
Contributor

@dgarske dgarske left a comment

Fix looks good. Thanks Daniel.

lib/vtls/wolfssl.c Show resolved Hide resolved
bagder added 2 commits Feb 11, 2022
Returning zero indicates end of connection, so if there's no data read
but the connection is alive, it needs to return -1 with CURLE_AGAIN.

Closes #8431
@bagder
Copy link
Member Author

@bagder bagder commented Feb 11, 2022

The user who ran into the problem that made me submit this PR to begin with, has confirmed that this fixes their problem.

@bagder bagder deleted the bagder/wolfssl-recv-zero branch Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants