wolfssl: when SSL_read() returns zero, check the error#8431
Closed
bagder wants to merge 2 commits into
Closed
Conversation
dgarske
reviewed
Feb 10, 2022
dgarske
left a comment
dgarske
left a comment
Contributor
There was a problem hiding this comment.
Fix looks good. Thanks Daniel.
jay
reviewed
Feb 11, 2022
Returning zero indicates end of connection, so if there's no data read but the connection is alive, it needs to return -1 with CURLE_AGAIN. Closes #8431
bagder
force-pushed
the
bagder/wolfssl-recv-zero
branch
from
81314eb to
c4b65cf
Compare
Member
Author
|
The user who ran into the problem that made me submit this PR to begin with, has confirmed that this fixes their problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning zero typically indicates end of connection, so if there's no
data read but the connection is alive, it needs to return -1 with
CURLE_AGAIN.