Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime: use a define instead of the magic number 24 #8441

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 11, 2022

MIME_BOUNDARY_DASHES is now the number of leading dashes in the
generated boundary string.

@monnerat approve?

MIME_BOUNDARY_DASHES is now the number of leading dashes in the
generated boundary string.
@monnerat
Copy link
Contributor

@monnerat monnerat commented Feb 11, 2022

approve?

Oh yes, and I think it has to be merged with pending PR #8423 as it targets the same code region. Do you want me to do it?

@bagder
Copy link
Member Author

@bagder bagder commented Feb 13, 2022

I can merge this one first as it is so simple, then you can just rebase your PR on master.

@bagder
Copy link
Member Author

@bagder bagder commented Feb 13, 2022

Oh, I merged the another one already so I will fix this.

@bagder bagder deleted the bagder/mime-24 branch Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants