New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects: Update VC version names for VS2017, VS2022 #8447
Conversation
85c8622
to
cec8edc
Compare
Why 14.1 and 14.30? Shouldn't it be 14.1 and 14.3 or 14.10 and 14.30? |
MS went from 14.1 to 14.11..14.30. I mistakenly thought VS 2022 was 14.3 but it's 14.30. The actual PlatformToolset is v143 though. |
I think you might be right, it is 14.10 and not 14.1. I will install Visual Studio 2017 to get the definitive answer. |
- Rename VC15 -> VC14.10, VC17 -> VC14.30. The projects directory that holds the pre-generated Visual Studio project files uses VC<ver> to indicate the MSVC version. At some point support for Visual Studio 2017 (Visual Studio version 15 which uses MSVC 14.10) was added as VC15. Visual Studio 2022 (Visual Studio version 17 which uses MSVC 14.30) project files were recently added and followed that same format using VC17. There is no such MSVC version (yet) as VC15 or VC17. For VS 2017 for example, the name we use is correct as either VS17, VS2017, VC14.10. I opted for the latter since we use VC for earlier versions (eg VC10, VC12, etc). Ref: curl#8438 (comment) Closes #xxxx
The VS 2017 Visual C++ RTM string is 14.10.25008.0 so I've renamed 14.1 => 14.10. Also, I forgot asked about this 5 years ago in an MS forum and a CSG told me I could use 14.1... |
Last call for feedback before I land this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not absolutely sure about YX.Z vs. XY.Z0, but looks good to me!
The projects directory that holds the pre-generated Visual Studio
project files uses VC to indicate the MSVC version. At some point
support for Visual Studio 2017 (Visual Studio version 15 which uses MSVC
14.10) was added as VC15. Visual Studio 2022 (Visual Studio version 17
which uses MSVC 14.30) project files were recently added and followed
that same format using VC17.
There is no such MSVC version (yet) as VC15 or VC17.
For VS 2017 for example, the name we use is correct as either VS17,
VS2017, VC14.10. I opted for the latter since we use VC for earlier
versions (eg VC10, VC12, etc).
Ref: #8438 (comment)
Closes #xxxx
Here is one way to do it.
/cc @MarcelRaad @snir
edit: Renamed 14.3 to 14.30, renamed 14.1 to 14.10