Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors when using GSKit #8454

Closed
wants to merge 3 commits into from
Closed

Fix build errors when using GSKit #8454

wants to merge 3 commits into from

Conversation

kadler
Copy link
Contributor

@kadler kadler commented Feb 15, 2022

Various changes in master have caused the GSKit build to break, which is used by the IBM i ILE (OS400) build.

kadler added 3 commits Feb 15, 2022
2f0bb86 replaced sterror with Curl_strerror, but the strerror buffer
shadows the set_buffer "buffer" parameter. To keep consistency with the
other functions that use Curl_strerror, rename the parameter.

In addition, strerror.h is needed for the definition of STRERROR_LEN.
In c30bf22, Curl_ssl_getsock was factored out in to a member of
struct Curl_ssl but the gskit initialization was not updated to reflect
this new member.
As mentioned in 32766cb, gskit was the last user of Curl_select which is
now gone. Convert to using Curl_poll to allow build to work on IBM i.
@kadler
Copy link
Contributor Author

@kadler kadler commented Feb 15, 2022

@NattyNarwhal can you look at these changes compare with the fixes you made?

@bagder bagder added the TLS label Feb 15, 2022
@NattyNarwhal
Copy link
Contributor

@NattyNarwhal NattyNarwhal commented Feb 15, 2022

I didn't have any changes other than what I made PRs for last; haven't looked at ILE curl in a while.

@kadler
Copy link
Contributor Author

@kadler kadler commented Feb 15, 2022

Ah, ok. I misunderstood and thought you meant you had changes outstanding.

@bagder
Copy link
Member

@bagder bagder commented Feb 16, 2022

Thanks!

bagder pushed a commit that referenced this issue Feb 16, 2022
In c30bf22, Curl_ssl_getsock was factored out in to a member of
struct Curl_ssl but the gskit initialization was not updated to reflect
this new member.

Closes #8454
bagder pushed a commit that referenced this issue Feb 16, 2022
As mentioned in 32766cb, gskit was the last user of Curl_select which is
now gone. Convert to using Curl_poll to allow build to work on IBM i.

Closes #8454
@kadler kadler deleted the gskit-fixes branch Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants