des: fix compile break for OpenSSL without DES#8459
Closed
MarcelRaad wants to merge 1 commit into
Closed
Conversation
Member
Author
|
All callers are here: https://github.com/curl/curl/blob/master/lib/curl_ntlm_core.c |
When `USE_OPENSSL` was defined but OpenSSL had no DES support and a different crypto library was used for that, `Curl_des_set_odd_parity` was called but not defined. This could for example happen on Windows and macOS when using OpenSSL v3 with deprecated features disabled. Use the same condition for the function definition as used at the caller side, but leaving out the OpenSSL part to avoid including OpenSSL headers. Closes curl#8459
MarcelRaad
force-pushed
the
fix_des_condition
branch
from
0beac03 to
0570303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
USE_OPENSSLwas defined but OpenSSL had no DES support and adifferent crypto library was used for that,
Curl_des_set_odd_paritywas called but not defined. This could for example happen on Windows
and macOS when using OpenSSL v3 with deprecated features disabled.
Use the same condition for the function definition as used at the
caller side, but leaving out the OpenSSL part to avoid including
OpenSSL headers.