schannel: Move the algIds array out of schannel.h#8469
Closed
JDepooter wants to merge 1 commit into
Closed
Conversation
This array is only used by the SCHANNEL_CRED struct in the schannel_acquire_credential_handle function. It can therefore be kept as a local variable. This is a minor update to bbb7150. This change also updates the NUM_CIPHERS value to accurately count the number of ciphers options listed in schannel.c, which is 47 instead of 45. It is unlikely that anyone tries to set all 47 values, but if they had tried, the last two would not have been set.
bagder
approved these changes
Feb 17, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This array is only used by the
SCHANNEL_CREDstruct in theschannel_acquire_credential_handlefunction. It can therefore be kept as a local variable. This is a minor update to bbb7150.This change also updates the
NUM_CIPHERSvalue to accurately count the number of ciphers options listed in schannel.c, which is 47 instead of 45. It is unlikely that anyone tries to set all 47 values, but if they had tried, the last two would not have been set.