Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: Move the algIds array out of schannel.h #8469

Closed

Conversation

JDepooter
Copy link
Contributor

@JDepooter JDepooter commented Feb 17, 2022

This array is only used by the SCHANNEL_CRED struct in the schannel_acquire_credential_handle function. It can therefore be kept as a local variable. This is a minor update to bbb7150.

This change also updates the NUM_CIPHERS value to accurately count the number of ciphers options listed in schannel.c, which is 47 instead of 45. It is unlikely that anyone tries to set all 47 values, but if they had tried, the last two would not have been set.

This array is only used by the SCHANNEL_CRED struct in the schannel_acquire_credential_handle function. It can therefore be kept as a local variable. This is a minor update to bbb7150.

This change also updates the NUM_CIPHERS value to accurately count the number of ciphers options listed in schannel.c, which is 47 instead of 45. It is unlikely that anyone tries to set all 47 values, but if they had tried, the last two would not have been set.
bagder
bagder approved these changes Feb 17, 2022
@bagder
Copy link
Member

@bagder bagder commented Feb 18, 2022

Thanks!

@JDepooter JDepooter deleted the move_algs_array_out_of_header branch Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants