Fixed BearSSL bug: TLS Session Resumption (session id) not working#8474
Closed
jan2000 wants to merge 1 commit into
Closed
Fixed BearSSL bug: TLS Session Resumption (session id) not working#8474jan2000 wants to merge 1 commit into
jan2000 wants to merge 1 commit into
Conversation
jay
reviewed
Feb 19, 2022
| } | ||
|
|
||
| if(!br_ssl_client_reset(&backend->ctx, hostname, 0)) | ||
| if(!br_ssl_client_reset(&backend->ctx, hostname, 1)) |
Member
There was a problem hiding this comment.
curl has its own session management. How does this affect the call to br_ssl_engine_set_session_parameters above?
Contributor
There was a problem hiding this comment.
Passing 0 here causes BearSSL to disable session resumption, so it won't resume a session with parameters set earlier. Passing 1 instead will cause BearSSL to actually use those parameters.
This was just an oversight on my part; I don't think I actually tested session resumption, so I forgot to enable it.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from: #8106
In
bearssl_connect_step1the functionbr_ssl_client_reset()is called withresume_sessionset to 0. This will make BearSSL clear the specified session id. Setting theresume_sessionparamater to 1 fixes this.