Skip to content

OS400 rpg include file fixes#8494

Closed
RobBoeckermann wants to merge 3 commits into
curl:masterfrom
RobBoeckermann:OS400-rpg-include-fix
Closed

OS400 rpg include file fixes#8494
RobBoeckermann wants to merge 3 commits into
curl:masterfrom
RobBoeckermann:OS400-rpg-include-fix

Conversation

@RobBoeckermann

Copy link
Copy Markdown

fixes typos within function declarations that were causing compilation errors when including the header in rpg code.

Rob B added 2 commits February 21, 2022 17:03
This resolves issues compiling rpg code that includes the curl header file.
Comment thread packages/OS400/curl.inc.in Outdated

@monnerat monnerat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though I have no rights to do this formally !

@bagder

bagder commented Feb 22, 2022

Copy link
Copy Markdown
Member

@monnerat that still works!

@bagder bagder closed this in eca5b6a Feb 22, 2022
bagder pushed a commit that referenced this pull request Feb 22, 2022
@bagder

bagder commented Feb 22, 2022

Copy link
Copy Markdown
Member

Thanks!

@monnerat

Copy link
Copy Markdown
Contributor

@monnerat that still works!

No, it doesn't ! I can leave a review comment, but the "Approve" radio button is locked with tooltip "Only users with explicit access to this repository may approve reviews"

@bagder

bagder commented Feb 22, 2022

Copy link
Copy Markdown
Member

I mean your comment here has basically the same effect for us anyway.

@monnerat

Copy link
Copy Markdown
Contributor

I mean your comment here has basically the same effect for us anyway.

That's what I hoped :-)
I'll use this way in the future whenever a new case occurs. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants