Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS400 rpg include file fixes #8494

Closed

Conversation

RobBoeckermann
Copy link

@RobBoeckermann RobBoeckermann commented Feb 22, 2022

fixes typos within function declarations that were causing compilation errors when including the header in rpg code.

Rob B added 2 commits Feb 22, 2022
This resolves issues compiling rpg code that includes the curl header file.
packages/OS400/curl.inc.in Outdated Show resolved Hide resolved
Copy link
Contributor

@monnerat monnerat left a comment

Approved, though I have no rights to do this formally !

@bagder
Copy link
Member

@bagder bagder commented Feb 22, 2022

@monnerat that still works!

bagder pushed a commit that referenced this issue Feb 22, 2022
@bagder
Copy link
Member

@bagder bagder commented Feb 22, 2022

Thanks!

@monnerat
Copy link
Contributor

@monnerat monnerat commented Feb 22, 2022

@monnerat that still works!

No, it doesn't ! I can leave a review comment, but the "Approve" radio button is locked with tooltip "Only users with explicit access to this repository may approve reviews"

@bagder
Copy link
Member

@bagder bagder commented Feb 22, 2022

I mean your comment here has basically the same effect for us anyway.

@monnerat
Copy link
Contributor

@monnerat monnerat commented Feb 22, 2022

I mean your comment here has basically the same effect for us anyway.

That's what I hoped :-)
I'll use this way in the future whenever a new case occurs. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants