libssh: #ifdef include files accordingly

[bagder]

Reported-by: 梦终无痕
Bug: https://curl.se/mail/lib-2022-02/0131.html

[illusory-dream]

S_IFLNK and S_IFMT will be undefined variable without including unistd.h. Could it work as expecting if we define them manually.

[bagder]

Could it work as expecting if we define them manually.

We can define them manually, sure. But isn't there a header file you can include that has them defined? Like maybe windows.h for example?

[bagder]

This fix seems to build on Windows now, at least with mingw

[gvanem]

This fix seems to build on Windows now, at least with mingw

I tried this diff and it works fine on MSVC + clang-cl too; curl.exe -k sftp://sftp.**.**

drwxr-xr-x    1 root     root          188 Feb 16 07:10 .
drwxr-xr-x    1 root     root          188 Feb 16 07:10 ..
drwxr-xr-x    3 root     root           60 Feb 26 11:33 customers
drwxr-xr-x    1 root     root           76 Feb 16 07:10 dev
drwxr-xr-x    1 root     root          756 Feb 16 07:10 etc
drwxr-xr-x    1 root     root           48 Dec  4  2020 lib
...

Except the typical problem with the peer certificate.

[gvanem]

But I noted that WSAStartup() is now called twice:

• In libcurl's Curl_win32_init().
• And libssh's ssh_socket_init().

Any way to avoid that?

[bagder]

It seems tricky because libssh has no apparent way to inhibit that. ssh_socket_init() is called from within ssh_init() but there's no way for us to tell it not to.

[jay]

But I noted that WSAStartup() is now called twice:

that's fine as long as there's a corresponding cleanup call. multiple startup calls increment an internal counter and it works the same as curl_global_init/cleanup.